Turn testing Python 2.6 in Travis on #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twisted has dropped Python 2.6 support, but fedmsg still needs to be Python 2.6 compatible. Since moksha.hub, the dependency that pulls in Twisted, doesn't require a specific version of Twisted, we can just install it before we install the requirements if the environment is Python 2.6. Signed-off-by: Jeremy Cline <jeremy@jcline.org>
This reverts commit 11a812f.
pypingou
reviewed
Oct 27, 2016
| - pip install -e .[commands,consumers] | ||
| - pip install nose mock sqlalchemy unittest2 |
There was a problem hiding this comment.
isn't unittest2 required in 2.6?
There was a problem hiding this comment.
It is, and it's placed in the tests_require list in setup.py
jeremycline
force-pushed
the
enable-2.6-testing
branch
3 times, most recently
from
49629ab
to
4af7adf
Compare
Signed-off-by: Jeremy Cline <jeremy@jcline.org>
jeremycline
force-pushed
the
enable-2.6-testing
branch
from
4af7adf
to
bd45211
Compare
|
I added a |
|
👍 for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twisted has dropped Python 2.6 support, but fedmsg still needs to be
Python 2.6 compatible. Since moksha.hub, the dependency that pulls in
Twisted, doesn't require a specific version of Twisted, we can just
install it before we install the requirements if the environment is
Python 2.6.
Signed-off-by: Jeremy Cline jeremy@jcline.org